# Date Author Comment Files Changed Download snapshot
e02feb62 8 months ago Stefan Brüns Declare PropertyInfo as QMetaType Summary: Required for data driven unit tests, probably useful elsewhere. No functional changes Test Plan: ctests Reviewers: #baloo, #frameworks, ngraham, astippich, apol Reviewed By: apol Subscribers: apol, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20031 2 zip | tar | tar.gz
1ac4253f 8 months ago Alexander Stippich Safeguard against invalid files Summary: Invalid vorbis files may crash in taglib due to a dereference on an invalid pointer. Explicitly check that the file is valid. Reviewers: bruns, ngraham Reviewed By: bruns, ngraham Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20082 1 zip | tar | tar.gz
e3276329 8 months ago Stefan Brüns [TagLibExtractor] Use the correct mimetype in case of inheritance Summary: The passed in mimetype may not match one of the explicitly supported types, but is supported by one of the parent types, e.g. audio/ogg. Use the new helper to fetch the correct parent mime type. Test Plan: ctest Reviewers: #baloo, #frameworks, ngraham, astippich Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20139 1 zip | tar | tar.gz
72d10bc0 8 months ago Stefan Brüns Add a helper to determine actual supported parent mime type Summary: The ExtractorCollection::fetchExtractors method falls back to ancestor mime types in case a type is not supported directly. For most extractors this is no problem, as these ignore the passed in mime type and rely on the backing library to figure out the type, while the taglibextractor requires one of the supported (container) types. For most cases the input type is returned, but it falls back to inheritance, matching the logic from ExtractorCollection::fetchExtractors. Reviewers: #baloo, #frameworks, ngraham, astippich Reviewed By: astippich Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20138 3 zip | tar | tar.gz
a4384d96 8 months ago Stefan Brüns [XmlExtractor] Add MathML test case Summary: Trivial test case Test Plan: ctest Reviewers: #baloo, #frameworks, ngraham, astippich Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20137 4 zip | tar | tar.gz
e1aae1f6 8 months ago Stefan Brüns [taglibextractor] Test extraction of properties with multiple values Summary: The taglib extractor can extract multiple values for one property, e.g. Genre and Artist. Test Plan: ctest Reviewers: #baloo, #frameworks, astippich, ngraham Reviewed By: #baloo, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20129 4 zip | tar | tar.gz
b56d0cb5 9 months ago Alexander Stippich Generate header for new MimeUtils 1 zip | tar | tar.gz
3a83a49a 9 months ago Alexander Stippich Use Qt function for string list formatting Summary: Reuse existing Qt function to convert string lists into string Reviewers: bruns Reviewed By: bruns Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20013 2 zip | tar | tar.gz
607286e9 9 months ago Alexander Stippich Fix number localization for properties Summary: Some properties were missing proper number localization Reviewers: bruns Reviewed By: bruns Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20012 1 zip | tar | tar.gz
67bcc588 9 months ago Stefan Brüns Verify mimetypes for all existing sample files, add some more Summary: Check if the mimetypes for the existing mimetypes can be determined correctly. Also add some samples which triggered false matches previously. Depends on D20045 Test Plan: ctest Reviewers: #baloo, #frameworks, astippich, ngraham, poboiko Reviewed By: #baloo, astippich, ngraham Subscribers: kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D20046 6 zip | tar | tar.gz
Per page